Added L1 to L2 message failure as a possible issue #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavo-grieco
changed the title
Contributor
|
@smonicas can you take a look at it? |
montyly
reviewed
Sep 28, 2022
|
|
||
| If a L1 message is never processed by the sequencer, users will never receive their tokens either in L1 or L2, so they need to way to cancel it. | ||
|
|
||
| As a more real example, a recent [AAVE audit](https://github.com/aave-starknet-project/aave-starknet-bridge/pull/106#issue-1336925381) highlighed this issue and required to add code to cancel messages. |
Contributor
There was a problem hiding this comment.
This can be moved to a Examples section at the bottom I think
smonicas
reviewed
Sep 29, 2022
not-so-smart-contracts/cairo/consider_L1_to_L2_message_failure.md
Outdated
Show resolved
Hide resolved
not-so-smart-contracts/cairo/consider_L1_to_L2_message_failure.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Simone <79767264+smonicas@users.noreply.github.com>
Co-authored-by: Simone <79767264+smonicas@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.